Skip to content

REL: 1.8.7#3639

Closed
effigies wants to merge 5 commits intomasterfrom
rel/1.8.7
Closed

REL: 1.8.7#3639
effigies wants to merge 5 commits intomasterfrom
rel/1.8.7

Conversation

@effigies
Copy link
Copy Markdown
Member

@effigies effigies commented Mar 20, 2024 •
edited
Loading

Preparation for the 1.8.7 release. It's just been a while and we have over 184 commits since the last release. This is not urgent.

The following users have made their first contributions:

Please let me know if you would like to be credited in releases, and if so what name, ORCID and affiliation you would like. See https://github.com/nipy/nipype/blob/master/.zenodo.json for examples. If you have already added yourself, no need to respond.

Quick issues/PRs:

  • ... Please let me know if you want to try to merge something in before the release.

Release checklist

  • Merge pending PRs
  • Update changelog
  • Update .mailmap
  • Update .zenodo.json
  • Set release number in nipype/info.py
  • Update doc/interfaces.rst with previous releases

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.90%. Comparing base (d52a62d) to head (391c238).
Report is 208 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3639   +/-   ##
=======================================
  Coverage   70.90%   70.90%           
=======================================
  Files        1277     1277           
  Lines       59477    59477           
  Branches     9819     9819           
=======================================
  Hits        42172    42172           
  Misses      16134    16134           
  Partials     1171     1171

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yibeichan
Copy link
Copy Markdown
Contributor

yibeichan commented Mar 21, 2024

thank you! but my PR was a very minor one...next time when I make more contributions I'll add myself

@effigies
Copy link
Copy Markdown
Member Author

effigies commented Mar 21, 2024

@djarecka Can you create a new TUTORIAL_ACCESS_TOKEN? I believe it's a PAT on https://github.com/miykael/nipype_tutorial. I do not have permissions there.

@djarecka
Copy link
Copy Markdown
Collaborator

djarecka commented Mar 21, 2024

@djarecka Can you create a new TUTORIAL_ACCESS_TOKEN? I believe it's a PAT on https://github.com/miykael/nipype_tutorial. I do not have permissions there.

TUTORIAL_ACCESS_TOKEN is nipype secret, I don't have admin access on nipype tutorial, but can try to update out secret with my PAT

@effigies
Copy link
Copy Markdown
Member Author

effigies commented Mar 21, 2024 •
edited
Loading

Token seems to work, but it looks like something went wrong with the action itself: https://github.com/miykael/nipype_tutorial/actions/runs/8376744890

@djarecka
Copy link
Copy Markdown
Collaborator

djarecka commented Mar 21, 2024

Token seems to work, but it looks like something went wrong with the action itself: https://github.com/miykael/nipype_tutorial/actions/runs/8376744890

yes, looks like there is problem with building

@effigies
Copy link
Copy Markdown
Member Author

effigies commented Mar 21, 2024

@mgxd I think you last fixed things related to DLC in miykael/nipype_tutorial#182. Any ideas?

@djarecka
Copy link
Copy Markdown
Collaborator

djarecka commented Mar 21, 2024

slightly more info here: https://github.com/miykael/nipype_tutorial/actions/runs/8377012805/job/22938063788

Can also take a look later today

@mgxd
Copy link
Copy Markdown
Member

mgxd commented Mar 21, 2024 •
edited
Loading

Looks like the DLC action we were using has been orphaned - there's a (somewhat) maintained fork here https://github.com/jpribyl/action-docker-layer-caching

@effigies effigies closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@effigies @yibeichan @djarecka @mgxd